Re: [PATCH] crypto: caam/qi - simplify CGR allocation, freeing

From: Herbert Xu
Date: Wed Oct 17 2018 - 02:26:18 EST


On Mon, Oct 08, 2018 at 02:09:37PM +0300, Horia GeantÄ wrote:
> CGRs (Congestion Groups) have to be freed by the same CPU that
> initialized them.
> This is why currently the driver takes special measures; however, using
> set_cpus_allowed_ptr() is incorrect - as reported by Sebastian.
>
> Instead of the generic solution of replacing set_cpus_allowed_ptr() with
> work_on_cpu_safe(), we use the qman_delete_cgr_safe() QBMan API instead
> of qman_delete_cgr() - which internally takes care of proper CGR
> deletion.
>
> Link: https://lkml.kernel.org/r/20181005125443.dfhd2asqktm22ney@xxxxxxxxxxxxx
> Reported-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Signed-off-by: Horia GeantÄ <horia.geanta@xxxxxxx>
> ---
> drivers/crypto/caam/qi.c | 43 ++++---------------------------------------
> drivers/crypto/caam/qi.h | 2 +-
> 2 files changed, 5 insertions(+), 40 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt