Re: [PATCH v4 2/4] crypto: mxs-dcp - Add support for dcp clk

[Leonard Crestez]

On Wed, 2018-10-17 at 09:48 -0300, Fabio Estevam wrote:
> On Wed, Oct 17, 2018 at 9:38 AM Leonard Crestez <leonard.crestez@xxxxxxx> wrote:
> > 
> > On 6ull and 6sll the DCP block has a clock which needs to be explicitly
> > enabled.
> > 
> > Add minimal handling for this at probe/remove time.
> > 
> > Signed-off-by: Leonard Crestez <leonard.crestez@xxxxxxx>
> 
> Please always explain what changed from the previous patch version.

There is a changelog in the cover letter.

> > +       /* Restart the DCP block. */
> > +       ret = stmp_reset_block(sdcp->base);
> > +       if (ret) {
> > +               dev_err(dev, "Failed reset\n");
> > +               goto err_disable_unprepare_clk;
> > +       }
> 
> This seems like an unrelated change that should be in a separate patch.
> 
> Also, this was not present in v3, so it is better to explain that this
> has been introduced in v4.

This only looks slightly odd in git diff but it's not unrelated.

I placed clk get/prepare/enable just before stmp_reset_block and made
stmp_reset_block print a message and goto err_disable_unprepare_clk on
failure instead of just "if (ret) return ret;"