Re: [PATCH 2/2] arm64: dts: qcom: sdm845: Add UFS nodes for sdm845-mtp

[Vivek Gautam]

On Wed, Oct 17, 2018 at 10:55 PM Evan Green <evgreen@xxxxxxxxxxxx> wrote:
>
> From: Can Guo <cang@xxxxxxxxxxxxxx>
>
> This change enables the UFS host controller and PHY on sdm845-mtp.
>
> Signed-off-by: Can Guo <cang@xxxxxxxxxxxxxx>
> Signed-off-by: Evan Green <evgreen@xxxxxxxxxxxx>
> ---
> I was unable to test this on an MTP, if somebody could give this a try I would
> be grateful. This applies atop agross/for-next, since it needs the regulators.
>
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> index eedfaf8922e2..d5fddea71a85 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -356,6 +356,20 @@
>         status = "okay";
>  };
>
> +&ufshc1 {
> +       status = "okay";
> +
> +       vcc-supply = <&vreg_l20a_2p95>;
> +       vcc-max-microamp = <600000>;
> +};
> +
> +&ufsphy1 {
> +       status = "okay";
> +
> +       vdda-phy-supply = <&vdda_ufs1_core>;
> +       vdda-pll-supply = <&vdda_ufs1_1p2>;
> +};
> +
>  &usb_1 {
>         status = "okay";
>  };
> --
> 2.16.4
>

Looks good.
Reviewed-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>

Best regards
Vivek

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation