Re: [PATCH 1/3] nfc: pn533: add UART phy driver

From: Lars Poeschel
Date: Thu Oct 18 2018 - 09:03:59 EST


On Wed, Oct 17, 2018 at 01:53:57PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 17, 2018 at 12:20:35PM +0200, Lars Poeschel wrote:
> > This adds the UART phy interface for the pn533 driver.
> > The pn533 driver can be used through UART interface this way.
> > It is implemented as a tty line discipline.
>
> Why not use the serdev interface instead?

Maybe because the most obivious is not obivious enough. ;)
I did not know about serdev before. Thank you very much for this! I am
almost finished migrating to serdev and everything is much cleaner and
more simple now!

I will post a follow-up with all your other comments addressed.

Thanks,
Lars