Re: [PATCH 2/3] uapi: get rid of STATX_ALL

From: David Howells
Date: Thu Oct 18 2018 - 11:16:52 EST


Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote:

> Constants of the *_ALL type can be actively harmful due to the fact that
> developers will usually fail to consider the possible effects of future
> changes to the definition.
>
> Remove STATX_ALL from the uapi, while no damage has been done yet.

You don't know that someone's not using it. It's been there a year and a
half, long enough. So, regretfully, I don't think we can remove it at this
point.

David