Re: [PATCH] clk: fixed-rate: fix of_node_get-put imbalance

From: Stephen Boyd
Date: Thu Oct 18 2018 - 16:22:48 EST


Quoting Alan Tull (2018-10-18 12:54:11)
> When the fixed rate clock is created by devicetree,
> of_clk_add_provider is called. Add a call to
> of_clk_del_provider in the remove function to balance
> it out.
>
> Signed-off-by: Alan Tull <atull@xxxxxxxxxx>
> ---

Fixes tag? I'll tack one on.

> drivers/clk/clk-fixed-rate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
> index b5c46b3f8764..6d6475c32ee5 100644
> --- a/drivers/clk/clk-fixed-rate.c
> +++ b/drivers/clk/clk-fixed-rate.c
> @@ -200,6 +200,7 @@ static int of_fixed_clk_remove(struct platform_device *pdev)
> {
> struct clk *clk = platform_get_drvdata(pdev);
>
> + of_clk_del_provider(pdev->dev.of_node);
> clk_unregister_fixed_rate(clk);
>
> return 0;