Re: [PATCH 4/8] PCI: consolidate PCI config entry in drivers/pci
From: Christoph Hellwig
Date: Fri Oct 19 2018 - 03:02:30 EST
On Fri, Oct 19, 2018 at 02:07:04PM +0900, Masahiro Yamada wrote:
> We could add 'depends on HAVE_PCI' or something
> to guard it to avoid changing the logic.
I guess that makes sense.
> config PCI_ENDPOINT
> bool "PCI Endpoint Support"
> depends on HAVE_PCI # Is this correct ??
> depends on HAS_DMA
>
>
> or better to have 'depends on PCI' ?
It does not depend on the normal PCI support, so I don't think this
is the right thing to do.