Re: [PATCH] pstore: Fix annotation on declaration of pstore_exit_fs

[Kees Cook]

On Fri, Oct 19, 2018 at 11:37 AM, Nathan Chancellor
<natechancellor@xxxxxxxxx> wrote:
> Clang warns (trimmed for brevity):
>
> fs/pstore/inode.c:504:6: error: section does not match previous
> declaration [-Werror,-Wsection]
> void __exit pstore_exit_fs(void)
>      ^
> fs/pstore/internal.h:42:6: note: previous attribute is here
> void __init     pstore_exit_fs(void);
>      ^
>
> Fixes: a4fb3d2fefd2 ("pstore: Centralize init/exit routines")
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> ---
>  fs/pstore/internal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/pstore/internal.h b/fs/pstore/internal.h
> index 98bb4fa6e6a7..7062ea4bc57c 100644
> --- a/fs/pstore/internal.h
> +++ b/fs/pstore/internal.h
> @@ -39,6 +39,6 @@ extern void   pstore_record_init(struct pstore_record *record,
>
>  /* Called during pstore init/exit. */
>  int __init     pstore_init_fs(void);
> -void __init    pstore_exit_fs(void);
> +void __exit    pstore_exit_fs(void);

Whoops! Thanks, I'll fold this fix into the patch.

-Kees

>
>  #endif
> --
> 2.19.1
>



-- 
Kees Cook
Pixel Security