Re: [PATCH] bpf/test_run: Add braces to initialization in bpf_prog_test_run_skb

[Eric Dumazet]

On 10/19/2018 11:26 AM, Nathan Chancellor wrote:
> Clang warns:
> 
> net/bpf/test_run.c:120:20: error: suggest braces around initialization
> of subobject [-Werror,-Wmissing-braces]
>         struct sock sk = {0};
>                           ^
>                           {}
> 
> Add the braces to properly initialize all subobjects.
> 
> Fixes: 75079847e9d0 ("bpf: add tests for direct packet access from CGROUP_SKB")
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> ---
>  net/bpf/test_run.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
> index 8dccac305268..65e049c61a7a 100644
> --- a/net/bpf/test_run.c
> +++ b/net/bpf/test_run.c
> @@ -117,7 +117,7 @@ int bpf_prog_test_run_skb(struct bpf_prog *prog, const union bpf_attr *kattr,
>  	u32 retval, duration;
>  	int hh_len = ETH_HLEN;
>  	struct sk_buff *skb;
> -	struct sock sk = {0};
> +	struct sock sk = { { {0} } };
>  	void *data;
>  	int ret;
>  
> 

Strange, I thought this patch was still under discussion.
Has an old version of it being merged somewhere ?