Re: [PATCH v14 12/12] cpuset: Show descriptive text when reading cpuset.sched.partition
From: Waiman Long
Date: Fri Oct 19 2018 - 15:32:24 EST
On 10/19/2018 03:24 PM, Tejun Heo wrote:
> On Fri, Oct 19, 2018 at 02:56:13PM -0400, Waiman Long wrote:
>> On 10/17/2018 11:08 AM, Tejun Heo wrote:
>>> On Mon, Oct 15, 2018 at 04:29:37PM -0400, Waiman Long wrote:
>>>> Currently, cpuset.sched.partition returns the values, 0, 1 or -1 on
>>>> read. A person who is not familiar with the partition code may not
>>>> understand what they mean.
>>>>
>>>> In order to make cpuset.sched.partition more user-friendly, it will
>>>> now display the following descriptive text on read:
>>>>
>>>> "normal" - A normal cpuset, not a partition root
>>>> "partition" - A partition root
>>>> "partition invalid" - An invalid partition root
>>>>
>>>> Suggested-by: Tejun Heo <tj@xxxxxxxxxx>
>>>> Signed-off-by: Waiman Long <longman@xxxxxxxxxx>
>>> Can you also make this consistent when writing to the file?
>>>
>>> Thanks.
>>>
>> How about the attached patch instead?
> Looks good to me. Once Peter is okay with it, I'll roll it into
> cgroup devel branch. As v4.19 is almost done, I think it makes more
> sense to target the next merge window (v4.21).
>
> Thanks.
>
v4.21 is fine. Thanks for valuable help and suggestions.
Cheers,
Longman