Re: [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement
From: Mark Brown
Date: Sun Oct 21 2018 - 07:23:26 EST
On Fri, Oct 19, 2018 at 11:22:46AM +0100, Jon Hunter wrote:
> Looking at snd_soc_init_platform(), it seems that the platform pointer
> can be allocated by the machine driver and so if it is not allocated by
> the core, then I don't think we should clear it here. Seems we need a
> way to determine if this was allocated by the core.
Indeed, this is a bit of a mess. We probably shouldn't be modifying the
data that the drivers passed in, otherwise we get into trouble like
this. That suggests that we should copy the data, probably all of it.
I will try to have a proper look at this next week.
> Furthermore, it seems that it is possible that there is more than one
> link that might be to be cleared.
Yes, that's an issue as well.
Attachment:
signature.asc
Description: PGP signature