Re: [PATCH 2/3] i2c:ocores: do not handle IRQ if IF is not set

From: Peter Korsgaard
Date: Sun Oct 21 2018 - 10:12:28 EST


On Mon, Jun 25, 2018 at 6:14 PM Federico Vaga <federico.vaga@xxxxxxx> wrote:
>
> If the Interrupt Flag (IF) is not set, we should not handle the IRQ:
> - the line can be shared with other devices
> - it can be a spurious interrupt
>
> To avoid reading twice the status register, the ocores_process() function
> expects it to be read by the caller.
>
> Signed-off-by: Federico Vaga <federico.vaga@xxxxxxx>

Looks good.

Acked-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>

--
Bye, Peter Korsgaard