Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

From: Dan Carpenter
Date: Mon Oct 22 2018 - 06:55:27 EST


On Mon, Oct 22, 2018 at 12:45:03PM +0200, Bernd Petrovitsch wrote:
> It's more like
> ---- snip ----
> case 3:
> frob();
> __fall_through;
> /* no break - fall through */
> case 4:
> ---- snip ----
> as "eclipse" doesn't accept anything else.
>
> And yes, it's far from "beautiful" but I hadn't time to dig into
> eclipses innards to fix that.
>

Doing both is super ugly. Let's just do comments until Eclipse gets
updated.

I had wanted to move to the attribute because that would simplify things
in Smatch but it's not a huge deal to delay for another year.

regards,
dan carpenter