Re: [PATCH 0/2] tracing: Fix synthetic event parser

From: Tom Zanussi
Date: Mon Oct 22 2018 - 16:14:57 EST


Hi Masami,

On Mon, 2018-10-22 at 00:07 +0900, Masami Hiramatsu wrote:
> Hi,
>
> I found another bug in synthetic event. This is a small fix, but
> confusingly, there is also a bug in a test case.
>
> Steve, since the testcase bugfix ([2/2]) breaks the test result
> unless corresponding fix ([1/2]), I would like to ask you to send
> these fixes from your tree.
> Shuah, could you give this your ack?
>

Yes, I think the silent failing mode is confusing to users, and so
these changes make more sense.

Acked-by: Tom Zanussi <zanussi@xxxxxxxxxxxxxxx>
Tested-by: Tom Zanussi <zanussi@xxxxxxxxxxxxxxx>

Thanks,

Tom


> Thank you,
>
> ---
>
> Masami Hiramatsu (2):
> tracing: Return -ENOENT if there is no target synthetic event
> selftests/ftrace: Fix synthetic event test to delete event
> correctly
>
>
> kernel/trace/trace_events_hist.c | 4 +++-
> .../trigger-synthetic-event-createremove.tc | 12 ++++++--
> ----
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> --
> Masami Hiramatsu (Linaro) <mhiramat@xxxxxxxxxx>