Re: [PATCH 01/20] ath6kl: Mark expected switch fall-through

[Steve deRosier]

On Mon, Oct 22, 2018 at 1:37 PM Gustavo A. R. Silva
<gustavo@xxxxxxxxxxxxxx> wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 201383 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
>  drivers/net/wireless/ath/ath6kl/main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
> index cb59016..5e7ea83 100644
> --- a/drivers/net/wireless/ath/ath6kl/main.c
> +++ b/drivers/net/wireless/ath/ath6kl/main.c
> @@ -389,6 +389,7 @@ void ath6kl_connect_ap_mode_bss(struct ath6kl_vif *vif, u16 channel)
>                 if (!ik->valid || ik->key_type != WAPI_CRYPT)
>                         break;
>                 /* for WAPI, we need to set the delayed group key, continue: */
> +               /* fall through */
>         case WPA_PSK_AUTH:
>         case WPA2_PSK_AUTH:
>         case (WPA_PSK_AUTH | WPA2_PSK_AUTH):
> --
> 2.7.4
>

Looks fine to me. Though it's too bad that the compiler can't detect
the fall through as already clearly commented.

Acked-by: Steve deRosier <derosier@xxxxxxxxxxxxxx>

- Steve