Re: [PATCH] Revert "workqueue: re-add lockdep dependencies for flushing"

From: Bart Van Assche
Date: Mon Oct 22 2018 - 17:47:57 EST


On Mon, 2018-10-22 at 22:14 +-0200, Johannes Berg wrote:
+AD4 I must also say that I'm disappointed you'd try to do things this way.
+AD4 I'd be (have been?) willing to actually help you understand the problem
+AD4 and add the annotations, but rather than answer my question (+ACI-where do I
+AD4 find the right git tree+ACIAIQ) you just send a revert patch.

Sorry that I had not yet provided that information. You should have
received this information through another e-mail thread. See also
http://lists.infradead.org/pipermail/linux-nvme/2018-October/020493.html.

+AD4 To do that, you have to understand what recursion is valid (I'm guessing
+AD4 there's some sort of layering involved), and I'm far from understanding
+AD4 anything about the code that triggered this report.

I don't think there is any kind of recursion involved in the NVMe code
that triggered the lockdep complaint. Sagi, please correct me if I got this
wrong.

Bart.