Re: [PATCH 19/20] rtlwifi: rtl8821ae: phy: Mark expected switch fall-through

From: Pkshih
Date: Mon Oct 22 2018 - 21:24:30 EST


On Mon, 2018-10-22 at 22:47 +0200, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
> Âdrivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 1 +
> Â1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> index 176deb2..a75451c 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> @@ -394,6 +394,7 @@ static void _rtl8812ae_phy_set_rfe_reg_24g(struct
> ieee80211_hw *hw)
> Â rtl_set_bbreg(hw, RB_RFE_INV, BMASKRFEINV, 0x000);
> Â break;
> Â }
> + /* fall through */
> Â case 0:
> Â case 2:
> Â default:

If BT isn't coexisting in the case 1, the settings will be the same as case 0/2.

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>