Re: [PATCH v4 1/5] mfd: rk808: Add RK817 and RK809 support

[tony]

> On Mon, 03 Sep 2018, Tony Xie wrote:
>
> >      The rk809 and rk817 are a Power Management IC (PMIC) for multimedia
> >      and handheld devices. It contains the following components:
> >
> >          - Regulators
> >          - RTC
> >          - Clocking
> >
> >      Both RK809 and RK817 chips are using a similar register map,
> >      so we can reuse the RTC and Clocking and regulators functionality.
> >
> > Signed-off-by: Tony Xie <tony.xie@xxxxxxxxxxxxxx>
> > ---
> It's often helpful to place a Changelog in this space.
ÂÂÂ I will output the changelog in the first mail when send-mail.
> >   drivers/mfd/Kconfig       |   6 +-
> >   drivers/mfd/rk808.c       | 218 +++++++++++++++++++++++++++++++++++++++++++++-
> >   include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++++
> >   kernel/reboot.c           |   1 +
> >   4 files changed, 391 insertions(+), 6 deletions(-)
> I just reviewed v4.
>
> It looks like the review comments are still relevant.
ÂÂÂ I will commit the v5 today which includes some modification base on 
your comments base in the v3.
>