Re: [PATCH] bonding:avoid repeated display of same link status change

From: Michal Kubecek
Date: Tue Oct 23 2018 - 12:26:18 EST


On Tue, Oct 23, 2018 at 09:10:44AM -0700, Eric Dumazet wrote:
>
>
> On 10/23/2018 08:54 AM, Mahesh Bandewar (àààà ààààààà) wrote:
>
> > Atomic operations are expensive (on certain architectures) and miimon
> > runs quite frequently. Is the added cost of these atomic operations
> > even worth just to avoid *duplicate info* messages? This seems like a
> > overkill!
>
> atomic_read() is a simple read, no atomic operation involved.
>
> Same remark for atomic_set()

Which makes me wonder if the patch really needs atomic_t.

Michal Kubecek