Re: [PATCH v2] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen'

From: Pkshih
Date: Tue Oct 23 2018 - 23:05:36 EST


On Tue, 2018-10-23 at 12:33 -0700, Joe Perches wrote:
> On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote:
> > radiob_array_table' and 'radiob_arraylen' are not used after setting its
> value.
> > It is safe to remove the unused variable. Meanwhile, radio B radio should be
> > removed as well. because it will no longer be referenced.
>
> The patch subject is a bit off and too generic here.
>
> This is specific to rtl8723ae and not rtlwifi so it is
> probably better for the subject to be something like:
>
> [PATCH] rtl8723ae: Remove set but not used variables and #defines

I'd like 'rtlwifi:Ârtl8723ae: ' as subject prefix.

>
> > Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
> > ---
> >ÂÂdrivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.cÂÂÂ| 5 +----
> >ÂÂdrivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ----
> >ÂÂdrivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 --
>
>
> ------Please consider the environment before printing this e-mail.