RE: [PATCH 2/3] dt-bindings: fpga: Add bindings for ZynqMP fpga driver

[Nava kishore Manne]

Hi Alan,

Thanks for the quick response..
Please find my response inline.

> -----Original Message-----
> From: Alan Tull [mailto:atull@xxxxxxxxxx]
> Sent: Monday, October 22, 2018 11:12 PM
> To: Nava kishore Manne <navam@xxxxxxxxxx>
> Cc: Moritz Fischer <mdf@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
> Mark Rutland <mark.rutland@xxxxxxx>; Michal Simek <michals@xxxxxxxxxx>;
> Rajan Vaja <RAJANV@xxxxxxxxxx>; Jolly Shah <JOLLYS@xxxxxxxxxx>; linux-
> fpga@xxxxxxxxxxxxxxx; open list:OPEN FIRMWARE AND FLATTENED DEVICE
> TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; moderated
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>;
> kishore m <chinnikishore369@xxxxxxxxx>
> Subject: Re: [PATCH 2/3] dt-bindings: fpga: Add bindings for ZynqMP fpga
> driver
> 
> On Fri, Oct 19, 2018 at 3:49 AM Nava kishore Manne
> <nava.manne@xxxxxxxxxx> wrote:
> 
> Hi Nava,
> 
> Just some nits, below.
> 
> >
> > Add documentation to describe Xilinx ZynqMP fpga driver bindings.
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@xxxxxxxxxx>
> > ---
> > Changes for v1:
> >                 Created a Seperate(New) DT binding file as
> >                 suggested by Rob.
> >
> > Changes for RFC-V2:
> >                 -Moved pcap node as a child to firwmare
> >                  node as suggested by Rob.
> >
> >  .../bindings/fpga/xlnx,zynqmp-pcap-fpga.txt     | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt
> > b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt
> > new file mode 100644
> > index 000000000000..248ff0ee60a8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt
> > @@ -0,0 +1,17 @@
> > +---------------------------------------------------------------------
> > +-----
> 
> Please get rid of all these '----' separators (in 4 places).
> 
Will fix in the next version.

> > +Device Tree zynqmp-fpga bindings for the Zynq Ultrascale+ MPSoC
> > +controlled using ZynqMP SoC firmware interface
> > +---------------------------------------------------------------------
> > +----- For Bitstream configuration on ZynqMp Soc uses processor
> > +configuration
> > +port(PCAP) to configure the programmable logic(PL) through PS by
> > +using FW interface.
> > +
> > +Required properties:
> > +- compatible: should contain "xlnx,zynqmp-pcap-fpga"
> > +
> > +-------
> > +Example
> 
> Nit: please add a colon so 'Example:'
Will fix in the next version

Regards,
Navakishore.