Re: [PATCH] thermal: add ratelimited thermal and power logging

From: Viresh Kumar
Date: Wed Oct 24 2018 - 03:22:34 EST

On 22-10-18, 14:29, Ross Zwisler wrote:
> From: Ricky Liang <jcliang@xxxxxxxxxxxx>
> Add thermal logs in devfreq_cooling and cpu_cooling.

Why should we add them ?

> Also add logging to
> power_allocator when it starts to control power.
> These changes can lead to excessive log spam when running up against
> thermal limits, so have this logging ratelimited to allow only 1 log each
> 30 seconds from each of those subsystems.

What's the use of these logs when we are going to print them only once every 30
seconds ?

I recently extended thermal sysfs support to share more stats.

commit 8ea229511e06 ("thermal: Add cooling device's statistics in sysfs")

Will that be helpful in your case ?

Otherwise we should probably add trace points instead.