Re: [v3 02/12] x86/fsgsbase/64: Add 'unsafe_fsgsbase' to enable CR4.FSGSBASE

From: Andy Lutomirski
Date: Wed Oct 24 2018 - 14:51:53 EST


On Tue, Oct 23, 2018 at 11:43 AM Chang S. Bae <chang.seok.bae@xxxxxxxxx> wrote:
>
> From: Andy Lutomirski <luto@xxxxxxxxxx>
>
> This is temporary. It will allow the next few patches to be tested
> incrementally.
>
> Setting unsafe_fsgsbase is a root hole. Don't do it.
>
> [ chang: Minor fix. Add the TAINT_INSECURE flag. ]

Reviewed-by: Andy Lutomirski <luto@xxxxxxxxxx>

although reviewing code that I mostly wrote seems a bit odd...