Re: [PATCH v8 08/12] mfd: intel-peci-client: Add PECI client MFD driver

[Jae Hyun Yoo]

On 10/24/2018 10:30 PM, Lee Jones wrote:
> On Wed, 24 Oct 2018, Jae Hyun Yoo wrote:
> > On 10/24/2018 3:59 AM, Lee Jones wrote:
> > > On Tue, 18 Sep 2018, Jae Hyun Yoo wrote:
> > >
> > > > This commit adds PECI client MFD driver.
> >
> > <snip>
>
> [...]
>
> > > > +bool peci_temp_need_update(struct temp_data *temp)
> > > > +{
> > > > +	if (temp->valid &&
> > > > +	    time_before(jiffies, temp->last_updated + UPDATE_INTERVAL))
> > > > +		return false;
> > > > +
> > > > +	return true;
> > > > +}
> > > > +EXPORT_SYMBOL_GPL(peci_temp_need_update);
> > > > +
> > > > +void peci_temp_mark_updated(struct temp_data *temp)
> > > > +{
> > > > +	temp->valid = 1;
> > > > +	temp->last_updated = jiffies;
> > > > +}
> > > > +EXPORT_SYMBOL_GPL(peci_temp_mark_updated);
> > >
> > > These are probably better suited as inline functions to be placed in
> > > a header file.  No need to export them, since they only use their own
> > > data.
>
> Also move them into the HWMON header file.
>
> They have no business in MFD.

Agreed. I'll move them into the HWMON header.

> [...]
>
> > > > +int peci_client_rd_pkg_cfg_cmd(struct peci_mfd *priv, u8 mbx_idx,
> > >
> > > This is gobbledegook.  What's rd?  Read?
> >
> > Yes, the 'rd' means 'read'. I intended to keep command names as listed
> > in the PECI specification such as RdPkgConfig, WrPkgConfig and so on.
> > Should I change it to 'peci_client_read_package_config_command' ?
>
> I looks/reads a lot nicer, don't you think?

Okay. I'll change it too.

Thanks again for your review, Lee!

Jae

> [...]