Re: [PATCH v3 0/3] iio: adc128s052: add matching options

[Andy Shevchenko]

On Thu, Oct 25, 2018 at 04:35:39PM +0100, Dan O'Donovan wrote:
> Hi all,
> 
> On some SKUs of AAEON's UP Squared board, there is an ADC124S101
> enumerated via ACPI. This is a pin-compatible variant of ADC124S021,
> which is already supported by the adc128s052 driver.
> 
> This patchset adds missing DT compatible strings for ADC124S021 (and
> ADC122S021) variants, adds AAEON's allocated ACPI HID, and adds the
> SPDX GPL identifier to the driver.
> 
> v2 was posted at:
> https://lore.kernel.org/lkml/20180423213805.12591-1-javier@xxxxxxxxxx/

Overall LGTM
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> 
> Changes from v2:
> * Added device-tree bindings documentation for new chip variants
> * Simplified code to get ACPI match data
> * Dropped redundant patch to facilitate OF matching via ACPI _DSD
> * Added patch to replace GPL license text with SPDX identifier
> 
> Changes from v1:
> * Improved patch descriptions and series title
> * Added an initial commit introducing new compatible strings
>   (as per Jonathan's suggestion)
> * Moved of_match_ptr removal last as this patch is less important to us
> 
> Dan O'Donovan (1):
>   iio: adc128s052: use SPDX-License-Identifier
> 
> Javier Arteaga (1):
>   iio: adc128s052: Add pin-compatible IDs
> 
> Nicola Lunghi (1):
>   iio: adc128s052: add ACPI _HID AANT1280
> 
>  .../devicetree/bindings/iio/adc/ti-adc128s052.txt  |  9 ++++-
>  drivers/iio/adc/ti-adc128s052.c                    | 39 +++++++++++++++++-----
>  2 files changed, 38 insertions(+), 10 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> ------
> This email has been scanned for spam and malware by The Email Laundry.
> 

-- 
With Best Regards,
Andy Shevchenko