Re: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding

[Rob Herring]

On Thu, Oct 18, 2018 at 08:40:11PM +0800, Icenowy Zheng wrote:
> å 2018-10-18åç 14:23 +0300ïLaurent Pinchartåéï
> > Hi Icenowy,
> > 
> > On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote:
> > > å 2018-10-18åç 11:53 +0300ïLaurent Pinchartåéï
> > > > On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
> > > > > The ANX6345 is an ultra-low power DisplayPort/eDP transmitter
> > > > > designed
> > > > > for portable devices.
> > > > > 
> > > > > Add a binding document for it.
> > > > > 
> > > > > Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
> > > > > ---
> > > > > 
> > > > >  .../bindings/display/bridge/anx6345.txt       | 39
> > > > > +++++++++++++++++++
> > > > > 
> > > > >  1 file changed, 39 insertions(+)
> > > > >  create mode 100644
> > > > > 
> > > > > Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > > 
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > > new
> > > > > file
> > > > > mode 100644
> > > > > index 000000000000..0689d4eb5f65
> > > > > --- /dev/null
> > > > > +++
> > > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > > @@ -0,0 +1,39 @@
> > > > > +Analogix ANX6345 eDP Transmitter
> > > > > +--------------------------------
> > > > > +
> > > > > +The ANX6345 is an ultra-low power Full-HD eDP transmitter
> > > > > designed
> > > > > for
> > > > > +portable devices.
> > > > > +
> > > > > +Required properties:
> > > > > +
> > > > > + - compatible		: "analogix,anx6345"
> > > > > + - reg			: I2C address of the device
> > > > > + - reset-gpios		: Which GPIO to use for reset
> > > > > +
> > > > > +Optional properties:
> > > > > +
> > > > > + - dvdd12-supply	: Regulator for 1.2V digital core
> > > > > power.
> > > > > + - dvdd25-supply	: Regulator for 2.5V digital core
> > > > > power.
> > > > 
> > > > Shouldn't these to supplies be mandatory ?
> > > 
> > > Yes they should.
> > > 
> > > > > + - panel-supply		: Regulator for the power of
> > > > > the panel.
> > > > 
> > > > Shouldn't the panel supply for specified in the DT node of the
> > > > panel
> > > > ?
> > > 
> > > However, eDP panel can be probed, may vary on the same device, and
> > > we
> > > don't have a generic binding for it...
> > 
> > Shouldn't we fix that ? :-)
> 
> Maybe we should create a connector binding instead of a panel binding?

There's not any such thing as a standard eDP connector, is there? 
Otherwise, that's just creating a generic panel binding in disguise. 
Maybe if eDP interface is standardized enough in terms of power control, 
control lines, EDID at least sometimes present, etc., then we could have 
some sort of generic eDP panel/connector binding.

Rob