Re: [RFC PATCH] mm: don't reclaim inodes with many attached pages

From: Sasha Levin
Date: Thu Oct 25 2018 - 17:44:56 EST

On Thu, Oct 25, 2018 at 01:27:07PM -0700, Matthew Wilcox wrote:
On Thu, Oct 25, 2018 at 04:20:14PM -0400, Sasha Levin wrote:
On Thu, Oct 25, 2018 at 12:44:42PM -0700, Andrew Morton wrote:
> Yup. Sasha, can you please take care of this?

Sure, I'll revert it from current stable trees.

Should 172b06c32b94 and this commit be backported once Roman confirms
the issue is fixed? As far as I understand 172b06c32b94 addressed an
issue FB were seeing in their fleet and needed to be fixed.

I'm not sure I see "FB sees an issue in their fleet" and "needs to be
fixed in stable kernels" as related. FB's workload is different from
most people's workloads and FB has a large and highly-skilled team of
kernel engineers. Obviously I want this problem fixed in mainline,
but I don't know that most people benefit from having it fixed in stable.

I don't want to make backporting decisions based on how big a certain
company's kernel team is. I only mentioned FB explicitly to suggest that
this issue is seen on real-life scenarios rather than on synthetic tests
or code review.

So yes, let's not run to fix it just because it's FB but also let's not
ignore it because FB has a world-class kernel team. This should be done
purely based on how likely this patch will regress stable kernels vs the
severity of the bug it fixes.