Re: [PATCH v1] arm64: dts: qcom: sdm845: Fix pcs_misc region address for UNI PHY

[Evan Green]

On Thu, Oct 25, 2018 at 1:38 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> Hi,
> On Thu, Oct 25, 2018 at 10:23 AM Manu Gautam <mgautam@xxxxxxxxxxxxxx> wrote:
> >
> > Correct address for pcs_misc register region of USB3 QMP UNI PHY.
> > These registers are used during runtime-suspend/resume routines
> > of phy.
> >
> > Fixes: ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes")
> > Signed-off-by: Manu Gautam <mgautam@xxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index b72bdb0a31a5..84bee81562a5 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -1156,7 +1156,7 @@
> >                                 reg = <0x88eb200 0x128>,
> >                                       <0x88eb400 0x1fc>,
> >                                       <0x88eb800 0x218>,
> > -                                     <0x88e9600 0x70>;
> > +                                     <0x88eb600 0x70>;
>
> Whoops, sorry for not noticing this earlier.  Thanks for the fix!
>
> Evan's most recent patch to the bindings [1] should also be fixed
> eventually too.  It feels like those patches have gone through enough
> spins though, so maybe we can just post this fix atop those?
>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> [1] https://lkml.kernel.org/r/20181024172735.154304-2-evgreen@xxxxxxxxxxxx

I'll spin mine. Incoming!