Re: [RFC PATCH 1/3] can: m_can: Create m_can core to leverage common code

From: Wolfgang Grandegger
Date: Sat Oct 27 2018 - 10:19:19 EST


Hello Dan,

for the RFC, could you please just do the necessary changes to the
existing code. We can discuss about better names, etc. later. For
the review if the common code I quickly did:

mv m_can.c m_can_platform.c
mv m_can_core.c m_can.c

The file names are similar to what we have for the C_CAN driver.

s/classdev/priv/
variable name s/m_can_dev/priv/

Then your patch 1/3 looks as shown below. I'm going to comment on that
one. The comments start with "***"....