Re: [RFC][PATCH] x86: ptrace: Add function argument access API

[Steven Rostedt]

On Fri, 12 Oct 2018 11:21:28 -0700
Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:

> On Fri, Oct 12, 2018 at 9:26 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> >
> > Anyone have any issues with this patch?
> >  
> 
> I'm conceptually okay with it.  That being said,
> regs_within_kernel_stack(), which you're indirectly using, is
> off-by-a-few.  And updating it to use probe_kernel_read() might be
> nice for robustness.
>

A patch to protect regs_within_kernel_stack() with
probe_kernel_read() has already been accepted. Can someone give an
Acked-by on this patch? As it does touch x86.

Thanks!

-- Steve