Re: [PATCH 03/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

[Sergei Shtylyov]

On 27.10.2018 12:58, Yu Chen wrote:

> This patch adds binding documentation to support usb hub and usb
> data role switch of Hisilicon HiKey&HiKey960 Board.
>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: John Stultz <john.stultz@xxxxxxxxxx>
> Cc: Binghui Wang <wangbinghui@xxxxxxxxxxxxx>
> Signed-off-by: Yu Chen <chenyu56@xxxxxxxxxx>
> ---
>  .../bindings/misc/hisilicon-hikey-usb.txt          | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt
>
> diff --git a/Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt b/Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt
> new file mode 100644
> index 000000000000..f94e990362c9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt
> @@ -0,0 +1,24 @@
> +Support usb hub and usb data role switch of Hisilicon HiKey&HiKey960 Board.
> +
> +-----------------------------
> +
> +Required properties:
> +- compatible: "hisilicon,gpio_hubv1","hisilicon,hikey960_usb"
> +- typc_vbus_int_gpio,typec-gpios: gpio to control the vbus of typeC port
> +- typc_vbus_enable_val: gpio value that enable the vbus of typeC port

   The part of the prop name preceding the comma is supposed to be vendor prefix.
Also hyphens are preferred to underscores.

> +- otg_gpio: gpio to switch DP&DM between the hub and typeC port
> +- hub_vdd33_en_gpio: gpio to enable the power of hub
> +- pinctrl-0: pinctrl config
[...]

MBR, Sergei