Re: [PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

From: Joe Perches
Date: Sat Oct 27 2018 - 18:58:00 EST


On Sat, 2018-10-27 at 22:28 +0200, Michael Straube wrote:
> The function rtw_hal_xmit() returns true or false.
> Change the return type from s32 to bool.
[]
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
[]
> @@ -598,7 +598,7 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt,
> * true dump packet directly
> * false enqueue packet
> */
> -s32 rtw_hal_xmit(struct adapter *adapt, struct xmit_frame *pxmitframe)
> +bool rtw_hal_xmit(struct adapter *adapt, struct xmit_frame *pxmitframe)
> {
> s32 res;

Does "s32 res" need changing to bool too?