Re: [PATCH v2 5/6] dt-bindings: drm/panel: simple: Innolux TV123WAM is actually P120ZDG-BF1

From: Andrzej Hajda
Date: Mon Oct 29 2018 - 05:11:00 EST

On 26.10.2018 00:21, Douglas Anderson wrote:
> As far as I can tell the bindings that were added in commit
> 9c04400f7ea6 ("dt-bindings: drm/panel: Document Innolux TV123WAM panel
> bindings") weren't actually for Innolux TV123WAM but were actually for
> Innolux P120ZDG-BF1.
> As far as I can tell the Innolux TV123WAM isn't a real panel and but
> it's a mosh between the TI TV123WAM and the Innolux P120ZDG-BF1.
> Let's unmosh.
> Here's my evidence:
> * Searching for TV123WAM on the Internet turns up a TI panel. While
> it's possible that an Innolux panel has the same model number as the
> TI Panel, it seems a little doubtful. Looking up the datasheet from
> the TI Panel shows that it's 1920 x 1280 and 259.2 mm x 172.8 mm.
> * As far as I know, the patch adding the Innolux Panel was supposed to
> be for the board that's sitting in front of me as I type this
> (support for that board is not yet upstream). On the back of that
> panel I see Innolux P120ZDZ-EZ1 rev B1.
> * Someone pointed me at a datasheet that's supposed to be for the
> panel in front of me (sorry, I can't share the datasheet). That
> datasheet has the string "p120zdg-bf1"
> * If I search for "P120ZDG-BF1" on the Internet I get hits for panels
> that are 2160x1440. They don't have datasheets, but the fact that
> the resolution matches is a good sign.
> While we doing the rename, also mention that no-hpd can be used with
> this panel. See the previous patch in this series ("drm/panel:
> simple: Add "no-hpd" delay for Innolux TV123WAM").
> Fixes: 9c04400f7ea6 ("dt-bindings: drm/panel: Document Innolux TV123WAM panel bindings")
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Cc: Sandeep Panda <spanda@xxxxxxxxxxxxxx>

Grats for good deduction.

Reviewed-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>