Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo

[lijiang]

å 2018å10æ29æ 16:31, Baoquan He åé:
> On 10/29/18 at 03:59pm, lijiang wrote:
>> diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c
>> index 4c8acdfdc5a7..de363796ed20 100644
>> --- a/arch/x86/kernel/machine_kexec_64.c
>> +++ b/arch/x86/kernel/machine_kexec_64.c
>> @@ -29,6 +29,9 @@
>>  #include <asm/setup.h>
>>  #include <asm/set_memory.h>
>>
>> +u64 sme_mask;
>> +EXPORT_SYMBOL(sme_mask);
> 
> Wondering why it is global. Who else will use it?
> 
In general, no need to export the symbol of local variable.

Ok, i will change it to a local variable and export it.

Thanks.
Lianbo

>> +
>>  #ifdef CONFIG_KEXEC_FILE
>>  const struct kexec_file_ops * const kexec_file_loaders[] = {
>>                 &kexec_bzImage64_ops,
>> @@ -357,6 +360,9 @@ void arch_crash_save_vmcoreinfo(void)
>>         vmcoreinfo_append_str("NUMBER(pgtable_l5_enabled)=%d\n",
>>                         pgtable_l5_enabled());
>>
>> +       sme_mask = sme_me_mask;
>> +       VMCOREINFO_NUMBER(sme_mask);
>> +
>>  #ifdef CONFIG_NUMA
>>         VMCOREINFO_SYMBOL(node_data);
>>         VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);