Re: [PATCH v2 01/17] compat_ioctl: add generic_compat_ioctl_ptrarg()
From: Arnd Bergmann
Date: Mon Oct 29 2018 - 05:50:22 EST
On Sun, Oct 28, 2018 at 6:07 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Sep 13, 2018 at 12:29:02PM +0200, Arnd Bergmann wrote:
> > I was hoping that the _ptrarg suffix gives enough warning here,
> > but maybe not. I was careful to only use it in cases that I
> > checked are safe, either using only pointer arguments, or
> > no arguments.
> > What we might do for further clarification (besides adding a
> > comment next to the declaration), would be to add a
> > complementary generic_compat_ioctl_intarg() that skips
> > the compat_ptr(). There are only a handful of drivers that
> > would use this though.
> ... and the next Monday zeniv went down until the end of September,
> so I'd missed any resends that might've happened in that window.
> It's _probably_ too late for this cycle, but let's deal with that
> thing properly for the next one.
Right, I don't think we're in a hurry, so I'll rebase my patches
once -rc1 is out and send you the new version.
> A couple of comments from rereading the thread:
> * generic_compat_ioctl_fthagn^H^H^H^H^H^Hptrarg should not
> be EXPORT_SYMBOL_GPL(). I'm sorry, but this is beyond ridiculous -
> "call native ioctl, with the last argument interpreted as an address
> from 32bit process POV and converted to 64bit equivalent" should
> not be copyrightable at all, and there's really only one natural
> way to express that. Use EXPORT_SYMBOL().
Sure, I didn't really give this much thought.
> And I'd consider names
> like compat_ptr_ioctl() - easier to type and less opaque...
> * rtc patch makes RTC_IRQP_SET32 et.al. accepted by 64bit
> syscall. Which is a behaviour change that might or might not be
> OK, but it needs to be clearly stated.
Yes. I was aware of the change in behavior and have done similar
changes for simplicity on y2038 ioctl patches in the past, but
you are right that this should be mentioned in the changelog.