Re: [PATCH 03/17] prmem: vmalloc support for dynamic allocation

From: Igor Stoppa
Date: Mon Oct 29 2018 - 14:07:35 EST




On 25/10/2018 01:26, Dave Hansen wrote:
On 10/23/18 2:34 PM, Igor Stoppa wrote:
+#define VM_PMALLOC 0x00000100 /* pmalloc area - see docs */
+#define VM_PMALLOC_WR 0x00000200 /* pmalloc write rare area */
+#define VM_PMALLOC_PROTECTED 0x00000400 /* pmalloc protected area */

Please introduce things as you use them. It's impossible to review a
patch that just says "see docs" that doesn't contain any docs. :)

Yes, otoh it's a big pain in the neck to keep the docs split into smaller patches interleaved with the code, at least while the code is still in a flux.

And since the docs refer to the sources, for the automated documentation of the API, I cannot just put the documentation at the beginning of the patchset.

Can I keep the docs as they are, for now, till the code is more stable?

--
igor