Re: [PATCH v2] codafs: Fix build using bare-metal toolchain

From: Andy Shevchenko
Date: Mon Oct 29 2018 - 16:08:58 EST


Cc: Arnd, I guess it might be useful for kernel-ci activity as well.

On Mon, Oct 29, 2018 at 10:05 PM Sam Protsenko
<semen.protsenko@xxxxxxxxxx> wrote:
>
> Hi Greg,
>
> On Mon, Oct 29, 2018 at 10:03 PM, Sam Protsenko
> <semen.protsenko@xxxxxxxxxx> wrote:
> > The kernel is self-contained project and can be built with bare-metal
> > toolchain. But bare-metal toolchain doesn't define __linux__. Because of
> > this u_quad_t type is not defined when using bare-metal toolchain and
> > codafs build fails. This patch fixes it by defining u_quad_t type
> > unconditionally.
> >
> > Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
> > ---
>
> Can you please pull this one, if this applicable? I sent it a while
> ago, but I guess it got lost in mailing list. It might be also
> applicable to stable branch (as it fixes allmodconfig build for ARM
> with bare-metal toolchain).
>
> Thanks!
>
> > include/linux/coda.h | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/include/linux/coda.h b/include/linux/coda.h
> > index d30209b9cef8..0ca0c83fdb1c 100644
> > --- a/include/linux/coda.h
> > +++ b/include/linux/coda.h
> > @@ -58,8 +58,7 @@ Mellon the rights to redistribute these changes without encumbrance.
> > #ifndef _CODA_HEADER_
> > #define _CODA_HEADER_
> >
> > -#if defined(__linux__)
> > typedef unsigned long long u_quad_t;
> > -#endif
> > +
> > #include <uapi/linux/coda.h>
> > #endif
> > --
> > 2.19.1
> >



--
With Best Regards,
Andy Shevchenko