RE: [PATCH v7 2/6] soc/fsl/guts: Add definition for LX2160A
From: Yinbo Zhu
Date: Mon Oct 29 2018 - 23:39:36 EST
-----Original Message-----
From: Poonam Aggrwal
Sent: 2018年10月29日 19:09
To: Vabhav Sharma <vabhav.sharma@xxxxxxx>; sudeep.holla@xxxxxxx; oss@xxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx; rjw@xxxxxxxxxxxxx; viresh.kumar@xxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; linux-kernel-owner@xxxxxxxxxxxxxxx; catalin.marinas@xxxxxxx; will.deacon@xxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; arnd@xxxxxxxx; kstewart@xxxxxxxxxxxxxxxxxxx; yamada.masahiro@xxxxxxxxxxxxx; Leo Li <leoyang.li@xxxxxxx>; shawnguo@xxxxxxxxxx
Cc: ulf.hansson@xxxxxxxxxx; Udit Kumar <udit.kumar@xxxxxxx>; Pankaj Bansal <pankaj.bansal@xxxxxxx>; linux@xxxxxxxxxxxxxxx; adrian.hunter@xxxxxxxxx; Varun Sethi <V.Sethi@xxxxxxx>; Vabhav Sharma <vabhav.sharma@xxxxxxx>; Yinbo Zhu <yinbo.zhu@xxxxxxx>
Subject: RE: [PATCH v7 2/6] soc/fsl/guts: Add definition for LX2160A
> -----Original Message-----
> From: linux-arm-kernel
> [mailto:linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx]
> On Behalf Of Vabhav Sharma
> Sent: Monday, October 29, 2018 2:28 PM
> To: sudeep.holla@xxxxxxx; oss@xxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> linuxppc-dev@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx; rjw@xxxxxxxxxxxxx;
> viresh.kumar@xxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx;
> linux-pm@xxxxxxxxxxxxxxx; linux-kernel-owner@xxxxxxxxxxxxxxx;
> catalin.marinas@xxxxxxx; will.deacon@xxxxxxx;
> gregkh@xxxxxxxxxxxxxxxxxxx; arnd@xxxxxxxx;
> kstewart@xxxxxxxxxxxxxxxxxxx; yamada.masahiro@xxxxxxxxxxxxx; Leo Li
> <leoyang.li@xxxxxxx>; shawnguo@xxxxxxxxxx
> Cc: ulf.hansson@xxxxxxxxxx; Udit Kumar <udit.kumar@xxxxxxx>; Pankaj
> Bansal <pankaj.bansal@xxxxxxx>; linux@xxxxxxxxxxxxxxx;
> adrian.hunter@xxxxxxxxx; Varun Sethi <V.Sethi@xxxxxxx>; Vabhav Sharma
> <vabhav.sharma@xxxxxxx>; Yinbo Zhu <yinbo.zhu@xxxxxxx>
> Subject: [PATCH v7 2/6] soc/fsl/guts: Add definition for LX2160A
>
> Adding compatible string "lx2160a-dcfg" to initialize guts driver for
> lx2160 and SoC die attribute definition for LX2160A
>
> Signed-off-by: Vabhav Sharma <vabhav.sharma@xxxxxxx>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@xxxxxxx>
> Acked-by: Li Yang <leoyang.li@xxxxxxx>
> ---
> drivers/soc/fsl/guts.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index
> 302e0c8..bcab1ee 100644
> --- a/drivers/soc/fsl/guts.c
> +++ b/drivers/soc/fsl/guts.c
> @@ -100,6 +100,11 @@ static const struct fsl_soc_die_attr fsl_soc_die[] = {
> .svr = 0x87000000,
> .mask = 0xfff70000,
> },
> + /* Die: LX2160A, SoC: LX2160A/LX2120A/LX2080A */
> + { .die = "LX2160A",
> + .svr = 0x87360000,
>Do all the threevariants " LX2160A/LX2120A/LX2080A" have same SVR?
Dear Poonam Aggrwal,
No, but the threevariants " LX2160A/LX2120A/LX2080A" has same svr value in this struct,
Because they all are variants of lx2160, the svr value in this struct is equal the soc svr && mask
Best Regards,
Yinbo Zhu.
> + .mask = 0xff3f0000,
> + },
> { },
> };
>
> @@ -222,6 +227,7 @@ static const struct of_device_id fsl_guts_of_match[] = {
> { .compatible = "fsl,ls1088a-dcfg", },
> { .compatible = "fsl,ls1012a-dcfg", },
> { .compatible = "fsl,ls1046a-dcfg", },
> + { .compatible = "fsl,lx2160a-dcfg", },
> {}
> };
> MODULE_DEVICE_TABLE(of, fsl_guts_of_match);
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flist
> s.infr
> adead.org%2Fmailman%2Flistinfo%2Flinux-arm-
> kernel&data=02%7C01%7Cpoonam.aggrwal%40nxp.com%7Cd9b7c36c786
> 54cd6dc4008d63d7fee63%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636764017001504288&sdata=pqFMlw6yVrHrvn4YRhqj%2FmoOnSscrZu
> tcoYn3In8OJc%3D&reserved=0