Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo

From: Dave Young
Date: Tue Oct 30 2018 - 01:09:12 EST


On 10/30/18 at 12:46pm, lijiang wrote:
> å 2018å10æ29æ 21:49, Borislav Petkov åé:
> > On Mon, Oct 29, 2018 at 09:41:26PM +0800, lijiang wrote:
> >>> VMCOREINFO_NUMBER(phys_base);
> >>> VMCOREINFO_SYMBOL(init_top_pgt);
> >>> vmcoreinfo_append_str("NUMBER(pgtable_l5_enabled)=%d\n",
> >>> pgtable_l5_enabled());
> >>>
> >>> + VMCOREINFO_NUMBER(sme_mask);
> >
> > What I'm still missing from the whole fun is where are we documenting
> > the contents of that vmcoreinfo thing?
> >
>
> I'm not sure whether the following document is what you need.
> Documentation/ABI/testing/sysfs-kernel-vmcoreinfo

It is not the content, I think it is a good catch from Boris, it would
be good to document the exported things in somewhere eg.
Documentation/kdump/vmcoreinfo.txt

>
> Thanks.
> Lianbo
> > If not, we need it documented.
> >

Thanks
Dave