Re: [PATCH 4/4] base/drivers/topology: Default dmpis-mhz if they are not set in DT

[Viresh Kumar]

On 30-10-18, 09:39, Daniel Lezcano wrote:
> SCHED_CAPACITY_SCALE is the default value in this file.
> 
> eg.
> 
> DEFINE_PER_CPU(unsigned long, cpu_scale) = SCHED_CAPACITY_SCALE
> ...
> pr_err("cpu_capacity: partial information: fallback to 1024 for all
> CPUs\n");
> ...
> 
> So I prefer to use the SCHED_CAPACITY_SCALE for consistency.

> Yes, it is the default behavior as stated in the documentation:
> 
> "capacity-dmips-mhz property is all-or-nothing: if it is specified for a
> cpu node, it has to be specified for every other cpu nodes, or the
> system will fall back to the default capacity value for every CPU."
> 
> and also in the error message:
> 
> pr_err("cpu_capacity: partial information: fallback to 1024 for all
> CPUs\n");

Okay.

-- 
viresh