Re: [PATCH 11/14] irq: add support for allocating (and affinitizing) sets of IRQs

From: Keith Busch
Date: Tue Oct 30 2018 - 13:38:08 EST


On Tue, Oct 30, 2018 at 11:33:51AM -0600, Jens Axboe wrote:
> On 10/30/18 11:22 AM, Keith Busch wrote:
> > On Tue, Oct 30, 2018 at 11:09:04AM -0600, Jens Axboe wrote:
> >> Pretty trivial, below. This also keeps the queue mapping calculations
> >> more clean, as we don't have to do one after we're done allocating
> >> IRQs.
> >
> > Yep, this addresses my concern. It less efficient than PCI since PCI
> > can usually jump straight to a valid vector count in a single iteration
> > where this only subtracts by 1. I really can't be bothered to care for
> > optimizing that, so this works for me! :)
>
> It definitely is less efficient than just getting the count that we
> can support, but it's at probe time so I could not really be bothered
> either.
>
> Can I add your reviewed-by?

Yes, please.

Reviewed-by: Keith Busch <keith.busch@xxxxxxxxx>

> --
> Jens Axboe