Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo
From: Borislav Petkov
Date: Wed Oct 31 2018 - 06:11:00 EST
On Wed, Oct 31, 2018 at 10:47:48AM +0800, Dave Young wrote:
> It is a mist only a few kdump people know them, documenting them will help
> people to understand and review. It will also be clearer instead of
> digging into code?
Wholeheartedly agreed. Especially if people start using vmcoreinfo for
other stuff, like live debugging:
> The document can briefly explain what is vmcoreinfo, why we need it, and
> some background info. Then list the exported values with some
> classifying by core kernel, arch related, string or number etc. For
> most of them like Baoquan said no need more explanation, but add
> explanations for something if needed like this sme mask.
And add explanations for *all* of them!
If this becomes an API, then it better be documented.
> But I think this can be done separately instead of blocking this patch.
We have three months to the next merge window - I'm sure you guys can do
Good mailing practices for 400: avoid top-posting and trim the reply.