Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

[Hans de Goede]

This is a multi-part message in MIME format.
Hi,

On 30-10-18 17:15, Dean Wallace wrote:
> On 30-10-18, Hans de Goede wrote:
> > Hi,
> >
> > On 30-10-18 16:46, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 30-10-18 16:04, Pierre-Louis Bossart wrote:
> > > > In addition I am not aware of any baytrail device using plt_clk_0,
> > > > so moving a common machine driver such a cht_bsw_max98090_ti to use
> > > > plt_clk0 only would break other devices (e.g. Rambi/Orco). Asking
> > > > for both clocks to be on might work though,
> > >
> > > Ok, so we need to have a DMI based quirk for the Swanky and maybe also
> > > the clapper to use plt_clk_0 there. Asking for 2 clks if we only need
> > > one does not seem like a good plan.
> >
> > Dean, Mogens,
> >
> > To write a proper patch for this I'm going to need DMI strings
> > from your devices.
> >
> > Can you please run (as normal user):
> >
> > grep . /sys/class/dmi/id/* 2> /dev/null
> >
> > And reply with the output of this command?
> Here's mine, for a coreboot uefi based swanky.
>
> https://ptpb.pw/~swanky-dmi-log

Thanks, can you give the attached patch a try. This does the same
as the previous one you tested, but then only on the Swanky.

Note I've added:

Reported-and-tested-by: Dean Wallace <duffydack73@xxxxxxxxx>

To the commit message, I hope that is ok with you, if not let me
know and I will drop it.

Once you can confirm that this version also fixes things I will
submit this version upstream.

Regards,

Hans