Re: [PATCH V4 4/5] misc/pvpanic: add support to get pvpanic device info by FDT

From: Andy Shevchenko
Date: Wed Oct 31 2018 - 08:53:52 EST


On Wed, Oct 31, 2018 at 7:27 AM Peng Hao <peng.hao2@xxxxxxxxxx> wrote:
>
> By default, when ACPI tables and FDT coexist for ARM64,
> current kernel takes precedence over FDT to get device information.
> Virt machine in qemu provides both FDT and ACPI table. This patch
> increases the way to get information through FDT.

> @@ -3,15 +3,18 @@

> * Copyright (C) 2013 Fujitsu.
> + * Copyright (C) 2018 ZTE.

> +#include <linux/acpi.h>
...
> -#include <linux/acpi.h>

> - { "", 0 },
> + { "", 0 }

These changes regarding to style should go in a separate patch.

> #include <linux/module.h>
> -#include <linux/init.h>

This one also in a separate patch.

So, the one should be split to three AFAICS.

--
With Best Regards,
Andy Shevchenko