Re: [PATCH 04/16] blk-mq: pass in request/bio flags to queue mapping

[Jens Axboe]

On 10/30/18 6:37 PM, Sagi Grimberg wrote:
> 
>>   static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q,
>> +						     unsigned int flags,
>>   						     unsigned int cpu)
>>   {
>>   	struct blk_mq_tag_set *set = q->tag_set;
>> @@ -84,7 +85,7 @@ static inline struct blk_mq_hw_ctx *blk_mq_map_queue_type(struct request_queue *
>>   							  unsigned int hctx_type,
>>   							  unsigned int cpu)
>>   {
>> -	return blk_mq_map_queue(q, cpu);
>> +	return blk_mq_map_queue(q, hctx_type, cpu);
>>   }
> 
> Haven't read through the rest of the patch set, but it looks a bit
> strange that a type enumeration is being passed on as flags field.

It's impossible to get it 100% right at this point, which is why
it looks a bit odd. If you read on, it'll make sense.

-- 
Jens Axboe