Re: [PATCH 17/28] tools include uapi: Update asound.h copy

[Arnaldo Carvalho de Melo]

Em Wed, Oct 31, 2018 at 10:27:02AM -0700, Joe Perches escreveu:
> On Wed, 2018-10-31 at 18:00 +0100, Takashi Iwai wrote:
> > On Wed, 31 Oct 2018 17:44:57 +0100,
> > Arnaldo Carvalho de Melo wrote:
> > > From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > > 
> > > To silence this perf build warning:
> > > 
> > >   Warning: Kernel ABI header at 'tools/include/uapi/sound/asound.h' differs from latest version at 'include/uapi/sound/asound.h'
> > >   diff -u tools/include/uapi/sound/asound.h include/uapi/sound/asound.h
> > > 
> > > Due to this cset:
> > > 
> > >   a98401518def ("ALSA: timer: fix wrong comment to refer to 'SNDRV_TIMER_PSFLG_*'")
> > > 
> > > Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> > > Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> > > Cc: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> > > Cc: Takashi Iwai <tiwai@xxxxxxx>
> > > Link: https://lkml.kernel.org/n/tip-76gsvs0w2g0x723ivqa2xua3@xxxxxxxxxxxxxx
> > > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > 
> > Thanks for the correction.
> > 
> > That's bad to have duped files that have to be synced manually...
> > At least, some checkpatch addition would help to suggest always
> > correct both places?
> 
> How could that work in checkpatch?

No need for changes.
 
> Wouldn't a symlink be simpler?

That would be equivalent to using it directly, see my response to
Takashi for a few of the reasons this is done this way.

- Arnaldo