Re: [PATCH 06/16] blk-mq: add 'type' attribute to the sysfs hctx directory

[Jens Axboe]

On 11/1/18 3:59 PM, Omar Sandoval wrote:
> On Tue, Oct 30, 2018 at 12:32:42PM -0600, Jens Axboe wrote:
>> It can be useful for a user to verify what type a given hardware
>> queue is, expose this information in sysfs.
>>
>> Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
>> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
>> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
>> ---
>>  block/blk-mq-sysfs.c | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
> 
> Out of curiousity, why sysfs instead of debugfs?

I don't feel that strongly about it, but it is a property
like the mapped CPUs, for instance, so kind of makes sense to
put it there rather than in debugfs.

-- 
Jens Axboe