Re: [PATCH v4] mm/page_owner: clamp read count to PAGE_SIZE

From: William Kucharski
Date: Thu Nov 01 2018 - 20:43:19 EST




> On Nov 1, 2018, at 3:47 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> - count = count > PAGE_SIZE ? PAGE_SIZE : count;
> + count = min_t(size_t, count, PAGE_SIZE);
> kbuf = kmalloc(count, GFP_KERNEL);
> if (!kbuf)
> return -ENOMEM;

Is the use of min_t vs. the C conditional mostly to be more self-documenting?

The compiler-generated assembly between the two versions seems mostly a wash.

William Kucharski