Re: [PATCH v2] x86/build: Build VSMP support only if CONFIG_PCI is selected

From: Juergen Gross
Date: Fri Nov 02 2018 - 03:13:13 EST


On 01/11/2018 19:27, Eial Czerwacki wrote:
> vsmp dependency on pv_irq_ops removed some years ago, so now let's clean
> it up from vsmp_64.c.
>
> In short, "cap & ctl & (1 << 4)" was always returning 0, as such we can
> remove all the PARAVIRT/PARAVIRT_XXL code handling that.
>
> However, the rest of the code depends on CONFIG_PCI, so fix it accordingly.
> in addition, rename set_vsmp_pv_ops to set_vsmp_ctl.
>
> Signed-off-by: Eial Czerwacki <eial@xxxxxxxxxxx>
> Acked-by: Shai Fultheim <shai@xxxxxxxxxxx>

While I'm still thinking selection of HYPERVISOR_GUEST and PARAVIRT
is a little bit strange, you can add:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen