Re: [PATCH 2/2] Compiler Attributes: auxdisplay: panel: use __fallthrough

From: Miguel Ojeda
Date: Fri Nov 02 2018 - 06:49:44 EST


Hi Dan,

On Tue, Oct 23, 2018 at 7:37 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> On Mon, Oct 22, 2018 at 07:10:02AM -0700, Kees Cook wrote:
> > I would prefer we continue to use the comment style until we've got
> > confirmed support for (at least) Clang, Coverity, CPPcheck, smatch,
> > and eclipse.
>
> Clang and Smatch don't support fall throught comments. Coverity
> supports both. CPPcheck is unknown.
>
> Eclipse doesn't support attributes. So it's just Eclipse and maybe
> CPP check.

Thanks for checking! Let's wait then a few months and see if we can
get cppcheck/Eclipse to support it.

Cheers,
Miguel